This repository was archived by the owner on Sep 9, 2020. It is now read-only.
pkg install honors versions when checking for conflicts#669
Merged
shomron merged 1 commit intoksonnet:masterfrom Jun 28, 2018
Merged
pkg install honors versions when checking for conflicts#669shomron merged 1 commit intoksonnet:masterfrom
shomron merged 1 commit intoksonnet:masterfrom
Conversation
Collaborator
Author
|
Exercising the change: |
Pull Request Test Coverage Report for Build 1082
💛 - Coveralls |
bryanl
reviewed
Jun 28, 2018
Member
bryanl
left a comment
There was a problem hiding this comment.
Could you removed the commented code if it isn't being used?
pkg/registry/cache_test.go
Outdated
| a.On("UpdateLib", lib.Name, lib).Return(nil) | ||
|
|
||
| var checker installedChecker | ||
| // checker.On("IsInstalled", pkg.Descriptor{ |
Member
There was a problem hiding this comment.
Is this coming back in the future, or should it be deleted?
Collaborator
Author
There was a problem hiding this comment.
The test may become more elaborate in the future - for now I'll take these out. 👍
Member
|
Will approve after the unused code is deleted. |
This commit allows installing a package when a different version is already installed. Currently, if the package is installed globally (the only option) - it will overwrite the previous version reference. A followup change will allow installing into environments to work around this limitation. Part of ksonnet#660 Also: * Add PackageManager.IsInstalled - fuzzy-match installation check for packages, without parsing their manifests Signed-off-by: Oren Shomron <shomron@gmail.com>
0086c51 to
d713640
Compare
Collaborator
Author
|
Removed unused code. |
bryanl
approved these changes
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows installing a package when a different version is
already installed. Currently, if the package is installed globally (the
only option) - it will overwrite the previous version reference.
A followup change will allow installing into environments to work around
this limitation.
Part of #660
Also:
Signed-off-by: Oren Shomron shomron@gmail.com