Add docker image resolver to param set#645
Conversation
Pull Request Test Coverage Report for Build 1041
💛 - Coveralls |
670bd2d to
bd1e8e8
Compare
underrun
left a comment
There was a problem hiding this comment.
some of the stuff removed in this PR doesn't seem fully relevant to resolving images from relative labels/tags - why is it necessary to remove them in this PR?
pkg/actions/actions.go
Outdated
| OptionPath = "path" | ||
| // OptionQuery is query option. | ||
| OptionQuery = "query" | ||
| // OptionResolveImage is resolve image option. It used to resolve docker image references |
| ) | ||
|
|
||
| const ( | ||
| mimeTypeDockerManifest = "application/vnd.docker.distribution.manifest.v2+json" |
There was a problem hiding this comment.
is it possible to use the OCI way of getting content addressable identifiers (with application/vnd.oci.descriptor.v1+json MIME type) or do we need to stay docker specific?
There was a problem hiding this comment.
No, in this case, application/vnd.docker.distribution.manifest.v2+json is the appropriate choice. With this MIME type, the server will set a header with the appropriate reference.
pkg/util/dockerregistry/resolver.go
Outdated
| } | ||
|
|
||
| // Digester resolves digests for a docker image. | ||
| type Digester interface { |
There was a problem hiding this comment.
this name feels off to me ... how about Identifier or ContentAddressableIdentifier
There was a problem hiding this comment.
I renamed it to ResolverClient
|
@underrun the code removed was all dead. It needed to be removed. |
bd1e8e8 to
3f3e1fa
Compare
|
@underrun ping |
Adds an image resolve to param set. eg: `ks param set deployment image foo/bar:latest` uses the docker registry to find the manifest reference for `foo/bar:latest`. It then sets this value instead. Support is at the component and environment level. Fixes ksonnet#569 Signed-off-by: bryanl <bryanliles@gmail.com>
3f3e1fa to
d3f430f
Compare
Adds an image resolve to param set. eg:
ks param set deployment image foo/bar:latest --resolve-imageuses the docker registry to find the manifest reference for
foo/bar:latest.It then sets this value instead. Support is at the component and environment
level.
Fixes #569
Signed-off-by: bryanl bryanliles@gmail.com