This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Remove defunct --version flag from registry add command#632
Merged
shomron merged 1 commit intoksonnet:masterfrom Jun 19, 2018
Merged
Remove defunct --version flag from registry add command#632shomron merged 1 commit intoksonnet:masterfrom
shomron merged 1 commit intoksonnet:masterfrom
Conversation
| # NOTE that "0.0.1" overrides the branch name in the URI ("master") | ||
| ks registry add databases github.com/example/tree/master/reg --version=0.0.1 | ||
| # 'github.com/org/example/tree/0.0.1/registry' (0.0.1 is the branch name) | ||
| ks registry add databases github.com/org/example/tree/0.0.1/registry --version=0.0.1` |
Collaborator
There was a problem hiding this comment.
Missed removing --version from the example
Collaborator
Author
There was a problem hiding this comment.
Good catch - updated.
Pull Request Test Coverage Report for Build 1025
💛 - Coveralls |
bryanl
approved these changes
Jun 19, 2018
93fdfcf to
4ecebd6
Compare
Signed-off-by: Oren Shomron <shomron@gmail.com>
4ecebd6 to
9b5e717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oren Shomron shomron@gmail.com