Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Registry cache behavior - do not pin specific version, automatic sliding forward on branches#622

Merged
shomron merged 1 commit intoksonnet:masterfrom
shomron:cache-behavior
Jun 19, 2018
Merged

Registry cache behavior - do not pin specific version, automatic sliding forward on branches#622
shomron merged 1 commit intoksonnet:masterfrom
shomron:cache-behavior

Conversation

@shomron
Copy link
Collaborator

@shomron shomron commented Jun 19, 2018 •
edited
Loading

...

Additional work:

  • Rework ks set update -> ks registry set
  • Registries are no longer versioned
  • Deprecation of GitVersion in configuration files

Issues:

Rework logic from #604.
Part of #237.

Signed-off-by: Oren Shomron shomron@gmail.com

@coveralls
Copy link

coveralls commented Jun 19, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1013

  • 190 of 330 (57.58%) changed or added relevant lines in 17 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.809%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/actions/init.go 0 1 0.0%
pkg/actions/registry_describe.go 0 1 0.0%
pkg/app/base_app.go 4 7 57.14%
pkg/app/app001.go 0 3 0.0%
pkg/app/app010.go 0 3 0.0%
pkg/util/github/github.go 0 4 0.0%
pkg/clicmd/registry_set.go 13 23 56.52%
pkg/registry/helm.go 6 18 33.33%
pkg/registry/schema.go 32 45 71.11%
pkg/registry/fs.go 4 22 18.18%
Files with Coverage Reduction New Missed Lines %
pkg/registry/github.go 3 64.54%
pkg/app/base_app.go 5 65.5%
Totals Coverage Status
Change from base Build 1007: -0.02%
Covered Lines: 10319
Relevant Lines: 14573
💛 - Coveralls

@bryanl
Copy link
Member

bryanl commented Jun 19, 2018

@shomron I'm assuming that package updating comes in a separate PR?

@shomron
Registry cache behavior - do not pin specific version, automatic slid…
4cd427d 
…ing forward on branches

Additional work:

* Rework ks set update -> ks registry set
* Registries are no longer versioned
* Deprecation of GitVersion in configuration files

Issues:

Rework logic from ksonnet#604.
Part of ksonnet#237.

Signed-off-by: Oren Shomron <shomron@gmail.com>
@shomron
Copy link
Collaborator Author

shomron commented Jun 19, 2018

I'm assuming that package updating comes in a separate PR?

Yep.

@shomron shomron merged commit db8f92e into ksonnet:master Jun 19, 2018
@shomron shomron deleted the cache-behavior branch June 19, 2018 14:01
@shomron shomron mentioned this pull request Jun 19, 2018
Open
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bryanl bryanl bryanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shomron @coveralls @bryanl