This repository was archived by the owner on Sep 9, 2020. It is now read-only.
enable env set to change server#612
Merged
underrun merged 1 commit intoksonnet:masterfrom Jun 14, 2018
Merged
Conversation
bryanl
suggested changes
Jun 14, 2018
| actions.OptionEnvName: args[0], | ||
| actions.OptionNewEnvName: viper.GetString(vEnvSetName), | ||
| actions.OptionNamespace: viper.GetString(vEnvSetNamespace), | ||
| actions.OptionServer: viper.GetString(vEnvSetServer), |
Member
There was a problem hiding this comment.
If you add a new option, you'll have to adjust the test to expect the new option.
Collaborator
Author
There was a problem hiding this comment.
add tests for both clicmd and actions
Pull Request Test Coverage Report for Build 991
💛 - Coveralls |
bryanl
approved these changes
Jun 14, 2018
adds --server flag to `ks env set` options also also fixes a couple bugs and adds version to INFO log on init Signed-off-by: Derek Wilson <derek@heptio.com>
07dbca9 to
e01cf4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds --server flag to
ks env setoptionsalso also fixes a couple bugs and adds version to INFO log on init