This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Merged
Conversation
Collaborator
|
@stang thanks for the PR! We prefer to include such upstream changes as part of a firm release - we've reached out to the jsonnet maintainers to find out when that can be expected. |
Member
|
@stang Would you mind updating this to the current master of jsonnet and rebasing off of our master? Also, could you review our DCO process and sign off your commit? https://github.com/ksonnet/ksonnet/blob/master/CONTRIBUTING.md |
Signed-off-by: Stephane Tang <hi@stang.sh>
Signed-off-by: Stephane Tang <hi@stang.sh>
Pull Request Test Coverage Report for Build 1093
💛 - Coveralls |
Author
|
Here we go @bryanl :) |
bryanl
approved these changes
Jul 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping
go-jsonnetto the current version so we can benefit of the massive performance improvement shipped in google/go-jsonnet#225.