Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Add component paths to jpath#501

Merged
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:component-jpath
May 11, 2018
Merged

Add component paths to jpath#501
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:component-jpath

Conversation

@bryanl
Copy link
Member

@bryanl bryanl commented May 2, 2018

Signed-off-by: bryanl bryanliles@gmail.com

Signed-off-by: bryanl <bryanliles@gmail.com>
@redbaron
Copy link
Contributor

redbaron commented May 2, 2018

components can use relative imports to reach their own files. cross components imports can't work reliably (import conflicts, version changes etc)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 849

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 4.567%

Totals Coverage Status
Change from base Build 848: 0.0%
Covered Lines: 19
Relevant Lines: 416

💛 - Coveralls

@bryanl
Copy link
Member Author

bryanl commented May 2, 2018

@redbaron The reason this PR is WIP is because I'm not sure this is a good idea. With the introduction of modules, there is a conflict with projects that have decided to use directories under components.

@redbaron
Copy link
Contributor

redbaron commented May 2, 2018

What is module?

Another argument against this change would be case where same package (prototype) is installed as different component names, we use it internally where generic-app is pulled in multiple times under different names by same app. Although currently all of them are using same pkg version, in the future there might be a case where some components are going to use different versions of the same pkg

@bryanl
Copy link
Member Author

bryanl commented May 11, 2018

@redbaron a module is a directory underneath components. Previously, it was a flat namespace. In order to support more flexible configurations, modules were introduced.

@bryanl bryanl changed the title WIP: Add component paths to jpath Add component paths to jpath May 11, 2018
@bryanl bryanl merged commit 958a626 into ksonnet:master May 11, 2018
@bryanl bryanl deleted the component-jpath branch May 11, 2018 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants