Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Fixing broken link in docs and also typos#439

Merged
bryanl merged 1 commit intoksonnet:masterfrom
Maerville:fixing_docs
Apr 13, 2018
Merged

Fixing broken link in docs and also typos#439
bryanl merged 1 commit intoksonnet:masterfrom
Maerville:fixing_docs

Conversation

@Maerville
Copy link
Contributor

Just a small fix :))
Link to Manifest anchor was broken in docs.
Actually same happened in website version https://ksonnet.io/docs/concepts

@bryanl
Copy link
Member

bryanl commented Apr 12, 2018

Hello, to accept PRs, you will need to sign our CLA.

https://github.com/ksonnet/ksonnet/blob/master/CONTRIBUTING.md

@Maerville
Copy link
Contributor Author

How to do it? :)

@bryanl
Copy link
Member

bryanl commented Apr 12, 2018

https://github.com/ksonnet/ksonnet/blob/master/DCO-SIGNOFF.md

You have to add a Signed-off-by to your commit message.

Signed-off-by: Elena <maerville@ya.ru>
@Maerville
Copy link
Contributor Author

Done, thanks

Copy link
Member

@bryanl bryanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanl bryanl merged commit 74f175a into ksonnet:master Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants