Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Incorrectly adds .metadata.labels to List objects #891

@redbaron

Description

@redbaron

/kind bug

What happened:

when component produces List object, ksonnet unconditionally adds .metadata.labels which doesn't pass validation, because List's .metadata is ListMeta (https://v1-11.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#listmeta-v1-meta) , not ObjectMeta

What you expected to happen:

no incorrect modifications being made to Lists objects

How to reproduce it (as minimally and precisely as possible):

make a component which returns List of Lists, example:

{ "apiVersion": "v1",
  "kind": "List",
  "items": [
      {
      "apiVersion": "rbac.authorization.k8s.io/v1",
      "items": [],
      "kind": "RoleBindingList"
      }
  ]
}

Anything else we need to know?:

Environment:

  • ksonnet version (use ks version): 0.13
  • Kubernetes version (use kubectl version): 1.11

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions