fix leaking the KRPC addon on each scene switch#779
Merged
djungelorm merged 1 commit intokrpc:mainfrom Mar 12, 2024
Merged
Conversation
…ndlers from static objects
Member
|
I don't follow how the leak occurs? Could you explain? |
djungelorm
requested changes
Mar 11, 2024
Contributor
Author
|
When you register an event handler, the publisher of the event holds on to a reference to the subscriber object. If the subscriber has a shorter lifetime than the publisher, it needs to unsubscribe from those events or it will never be garbage collected because of the lingering references. Lambdas are particularly tricky because you cannot easily remove them from an event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by unhooking event handlers from static objects