Skip to content

Symbols not exported when krpc library is compiled in Visual Studio #474

New issue
New issue
Closed
Closed
Symbols not exported when krpc library is compiled in Visual Studio#474
Labels
client:cpp
Milestone
0.4.7
@nullprofile

Description

@nullprofile
nullprofile
opened on Jun 10, 2018

Compiling the C++ client library with Visual Studio 2017 results in no .lib being generated.
Adding set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) after line 29 in CMakeLists.txt fixes this. Requires CMake 3.4 or newer.

krpc/client/cpp/CMakeLists.txt.tmpl

Lines 29 to 38 in 70ff446

if(MSVC)
# protobuf statically links against MT, so need to compile with /MT not /MD
foreach(var
CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
if(${var} MATCHES "/MD")
string(REGEX REPLACE "/MD" "/MT" ${var} "${${var}}")
endif()
endforeach()
endif()

Metadata

Metadata

Assignees

No one assigned

    Labels

    client:cpp

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions