Remove iouring support from simple test client#3189
Remove iouring support from simple test client#3189robobario merged 1 commit intokroxylicious:mainfrom
Conversation
SamBarker
left a comment
There was a problem hiding this comment.
I'm sad to see this PR but I just don't have the cycles to look deeper.
Once the build failure is fixed:
Error: Unused declared dependencies found:
Error: io.netty:netty-transport-classes-io_uring:jar:4.2.9.Final:compile
I think you can tag this as fixing: #3120
This was a copy-paste job from the production event group config. We hit on a test regression where netty threads on corretto 25 were failing to be cleaned up on close. They were stuck in: ``` at io.netty.util.internal.CleanerJava25$CleanableDirectBufferImpl.clean(CleanerJava25.java:206) ``` This eventually caused tests to time out due to resource issues. Signed-off-by: Robert Young <robertyoungnz@gmail.com>
fb94d64 to
9264f73
Compare
I'll try to make a simpler reproducer for the netty team, it looks like a bad combo of iouring/java25-corretto |
Tag me on that ticket when you do please |
|
|
|
merging without sonar coverage % passing, unit testing the crossplatform support has been fragile to mock out in the past (need to mock static methods). |
Type of change
Description
Resolves #3188
Resolves #3120
Integration tests on corretto 25 on main push are currently failing reliably. Debugging showed that netty threads were piling up, stuck trying to teardown IOUring resources. IOUring is the default implementation picked by the
io.kroxylicious.test.client.KafkaClienttest client we use to send single RPCs at the proxy and these new AuthZ tests started creating many of these throwaway clients, causing big growth in threads over time.This was a copy-paste job from the production event group config. We never really cared about IOUring for this integration test client and have talked about removing it before.
Checklist
Please go through this checklist and make sure all applicable tasks have been done