Merge canis ursa refactor with ess#64
Merged
Merged
Conversation
Merge solar sensors into a single sun power dict. Add solar binary sensors into a single sun power binary dict. Add sun vault sensors into a single sun vault dict. Add sun vault binary sensors into a single sun vault binary dict. Modify entity to have a single entity class. Modify sensors to utilize new solar sensor dict and optionally sun vault sensor dict including utilization of singular sensor class. Modify binary sensors to utilize new solar binary sensor dict and optionally sun vault binary sensor dict including utilization of singular binary sensor class. Add method for querying energy storage system status. Update sunpower fetch to include querying energy storage system and generating the abstract sunvault for dealing with systems containing multiple batteries. Update readme to include information about energy storage system. Add use ess option to config flow.
…d to get ESS data to fail with: UnboundLocalError: cannot access local variable 'data' where it is not associated with a value
…(cleaned up README.md)
…ltered to protect the innocent)
a bit of lag causing the poller to come back right before we would actually want to poll.
…vice so that it will be unique
different (collecting some special fields)
in names. update README to reflect these updates
* make sure to always use the passed in product name vs. hard coded * if the beginning entity name matches the device name it will be stripped in the UI where it makes sense (viewing the device) but still used in the entity name (best of both worlds)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #63 and issue #45 (because I was there). Currently this also changes all entity ids so all historical data and graphs will break :-( I'm going to do a bit more review of the 'why' on these to see if I really want to push this out.
This change is with much thanks to @CanisUrsa a lot of nice cleanup that enable at least one other feature request in the future (debug values should be easy/clean)