feat: add Cross-Section Slice Plane (Feature 10) + Measurement Tool fixes (Feature 9)#20
Merged
kraulerson merged 16 commits intomainfrom Apr 9, 2026
Merged
feat: add Cross-Section Slice Plane (Feature 10) + Measurement Tool fixes (Feature 9)#20kraulerson merged 16 commits intomainfrom
kraulerson merged 16 commits intomainfrom
Conversation
…ing pipeline Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…anager Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…positioning Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…pdate hooks to MainWindow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bug 1: In measure mode, left-click was passed to VTK interactor which started orbit rotation. Fix: consume left press/move/release in measure mode so VTK never sees the events. Right-click and scroll still work. Bug 2: Slice plane interactor was obtained via roundabout chain (GetRenderWindow().GetInteractor()) which may return wrong object. Fix: pass QVTKRenderWindowInteractor directly since it IS the interactor. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… fixes - test_event_filter_consumes_left_press: verifies left-click is consumed in measure mode - test_event_filter_passes_right_press: verifies right-click passes through to VTK - test_slice_activates_with_loaded_mesh: verifies slice plane activates with direct interactor - test_slice_deactivates_on_uncheck: verifies clean deactivation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
28 scenarios: 17 for Measurement Tool, 11 for Cross-Section Slice Plane. Covers point placement, FIFO, navigation in measure mode, clearing, invalidation, slice presets, drag/rotate, persistence, and edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… render)
UAT5-016: Add vtk_render() call after measurement invalidation so
cleared measurements disappear visually on undo.
UAT5-020: Increase plane widget handle size (SetHandleSize 15.0) and
PlaceFactor (1.25) for easier grabbing.
UAT5-022/023/024/025: Fix remaining GetRenderWindow().GetInteractor()
calls in undo/redo/repair/transform handlers — pass
vtk_interactor directly. Fix InsideOut on fallback clipper.
UAT5-026: Replace keyPressEvent with window-level QShortcut for Escape
so it works regardless of which widget has focus.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
UAT5-020/022-025: Overlay was compressed to invisible size. Increased width (110->130), added minHeight(100), enlarged button padding and font size, removed debug prints. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All scenarios for Features 9 (Measurement Tool) and 10 (Cross-Section Slice Plane) passing. No open bugs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use Any type for _widget (VTK widget lacks mypy stubs) - Cast AddObserver event name via Any to satisfy arg-type check - Add no-any-return ignore for vtkClipPolyData.GetOutput() Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Feature 10 Implementation
SlicePlaneManager— VTK clipping pipeline with vtkClipClosedSurface + vtkClipPolyData fallbackSliceOverlayWidget— floating Qt panel with preset buttons and dark themeSceneManager— delegation methods for activate/deactivate/preset/reset/updateMainWindow— C key toggle, Escape via QShortcut, overlay signals, mesh update hooksPROJECT_BIBLE.md— added--include-module=vtkmodules.vtkInteractionWidgetsFeature 9 Fixes (from UAT testing)
Test plan
🤖 Generated with Claude Code