tests: Fix test flake from timestamp sanitization (#2713)#2742
Merged
martinmaly merged 1 commit intokptdev:porchfrom Feb 4, 2022
martinmaly:flake
Merged
tests: Fix test flake from timestamp sanitization (#2713)#2742martinmaly merged 1 commit intokptdev:porchfrom martinmaly:flake
martinmaly merged 1 commit intokptdev:porchfrom
martinmaly:flake
Conversation
* Fix test flake from timestamp sanitization When timestamps "overlap", sanitization did not work correctly. For example: in 1s ... in 2.1s The first substitution would replace 1s => 0s in 0s ... in 2.0s The second substitution is predetermined, and replaces 2.1s => 0s, but 2.1s is no longer in the string. * Use new sanitization function in tests, remove old function
justinsb
approved these changes
Feb 4, 2022
Contributor
justinsb
left a comment
There was a problem hiding this comment.
Not sure if I can approve,but lgtm :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When timestamps "overlap", sanitization did not work correctly.
For example:
in 1s ... in 2.1s
The first substitution would replace 1s => 0s
in 0s ... in 2.0s
The second substitution is predetermined, and replaces 2.1s => 0s, but
2.1s is no longer in the string.