git: create ApprovePackageRevision method, remove draft hack#2712
Merged
justinsb merged 2 commits intokptdev:porchfrom Feb 3, 2022
Merged
git: create ApprovePackageRevision method, remove draft hack#2712justinsb merged 2 commits intokptdev:porchfrom
justinsb merged 2 commits intokptdev:porchfrom
Conversation
68548b1 to
550263a
Compare
Now that we can approve a package (in our tests at least), we can now fetch the package on the non-draft ref.
550263a to
216a2ab
Compare
Contributor
Author
|
Flake is #2713; will force retest |
We want to pick up go-git/go-git#325
216a2ab to
21401f0
Compare
martinmaly
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we can approve a package (in our tests at least), we can now fetch the package on the non-draft ref.
Also update go-git to HEAD, to pick up go-git/go-git#325