Let Corepack add a packageManager property to package.json#632
Merged
ExplodingCabbage merged 1 commit intomasterfrom Oct 6, 2025
Merged
Let Corepack add a packageManager property to package.json#632ExplodingCabbage merged 1 commit intomasterfrom
ExplodingCabbage merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run any yarn commands in the jsdiff repo on my current dev machine (which has an installation of Node 24 that shipped with Corepack), Corepack automatically asks to install Yarn 1 and automatically adds a
packageManagerkey topackage.json. I vaguely recall that certain scripts in this repo do (or at least once did) specifically need Yarn 1 so this is probably appropriate. Might as well commit the automatic change.