fix: export ArrayChange type#626
Merged
ExplodingCabbage merged 2 commits intokpdecker:masterfrom Jul 29, 2025
bdkopen:export-arraychange
Merged
fix: export ArrayChange type#626ExplodingCabbage merged 2 commits intokpdecker:masterfrom bdkopen:export-arraychange
ExplodingCabbage merged 2 commits intokpdecker:masterfrom
bdkopen:export-arraychange
Conversation
Collaborator
|
Huh, interesting. It's a bit odd that I included a type with the same name here but make the type slightly different (not parameterized like the old DefinitelyTyped version) and didn't export it; clearly what I did doesn't make sense and must've been a mistake. I think I see three options here would seem to be:
|
Collaborator
|
I think I'll go for the third option, just to minimise the compatibility break. Versions 5 and 7 still collectively have 15x the downloads that version 8 has, so making the upgrade path more painless does still have value, notwithstanding that it's been months since I released version 8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ArrayChangeto the type exports. This was originally exported as part of the@types/diffpackage (code), but isn't exported here. Including it will make the v8 type update simpler.Alternatively, we could cut the type altogether since it hasn't been exported since the v8 release.