Split file using all possible line delimiter instead of hard-coded "/n" and join lines back using the original delimiters#144
Merged
kpdecker merged 7 commits intokpdecker:masterfrom Nov 27, 2016
soulbeing:SpliteFile
Merged
Split file using all possible line delimiter instead of hard-coded "/n" and join lines back using the original delimiters#144kpdecker merged 7 commits intokpdecker:masterfrom soulbeing:SpliteFile
kpdecker merged 7 commits intokpdecker:masterfrom
soulbeing:SpliteFile
Conversation
…n" and join lines back using the original delimeters Change-Id: I8428395071744f78e19dd96e81c1b6bc7ca1126e Signed-off-by: Sidney <jiangxin87@qq.com>
Change-Id: Idd56dfba2f2764a2937226fde566c8ef3abf487c Signed-off-by: Sidney <jiangxin87@qq.com>
Change-Id: Ie464bfbde8d34d3f63c999226a646f01b71c012f Signed-off-by: Sidney <jiangxin87@qq.com>
Change-Id: I1e7ec5aa0c83148d3ffbb0e746fa8643b5c46b07 Signed-off-by: Sidney <jiangxin87@qq.com>
Change-Id: I301f5e4822582689116bb5ba61228ed28d0fd1be Signed-off-by: Sidney <jiangxin87@qq.com>
Change-Id: Id3e3f4f23249e07d02b4dc34207368a7eeee7ad5 Signed-off-by: Sidney <jiangxin87@qq.com>
Owner
|
Released in 3.1.0 |
Collaborator
|
@soulbeing do you remember what this was supposed to fix? The overall behaviour change effected by this PR is non-obvious and there are no tests demonstrating it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split file using all possible line delimiter instead of hard-coded "/n" and join lines back using the original delimiters.
let me know your feed back on this please.