Skip to content

callback option has a weird signature #462

@ExplodingCabbage

Description

@ExplodingCabbage

The diffing functions take a (currently undocumented) callback option. If provided, the diff is calculated in async mode and the result is passed as the second argument to the callback function.

Unless I'm missing something, the first argument is just... never provided. It's always undefined, whether the diff is calculated successfully or not.

This seems pretty bizarre. We should just eliminate the first argument.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions