#92 Adds a Relude.Extra.Tuple module#93
Merged
chshersh merged 28 commits intokowainik:masterfrom Oct 6, 2018
cronokirby:92-Extra.Tuple
Merged
#92 Adds a Relude.Extra.Tuple module#93chshersh merged 28 commits intokowainik:masterfrom cronokirby:92-Extra.Tuple
chshersh merged 28 commits intokowainik:masterfrom
cronokirby:92-Extra.Tuple
Conversation
…ge version to 0.3.1
chshersh
approved these changes
Oct 6, 2018
Contributor
chshersh
left a comment
There was a problem hiding this comment.
Looks quite good! Thanks for the contribution!
| >>> mapToFst (+1) 10 | ||
| (11,10) | ||
| -} | ||
| mapToFst :: (a -> b) -> a -> (b, a) |
Contributor
There was a problem hiding this comment.
Hmm, mapToFst name is also kinda nice 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #92
I've opted with
mapToFstto denote the function where the result ends up in the first slot,instead of
mapSnd. The names of these are of course an easy fix, if that's what we decide to do.I've preemptively inlined everything in the module, which should be fine given the size of every function.
I haven added any hlint rules, I think that should be a separate issue if this gets merged.
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
.hlint.yamlfile (seethis instructions).
General
with the short description of my latest changes.
for more details).
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.