Skip to content

Switch from criterion to tasty-bench#410

Merged
chshersh merged 1 commit intokowainik:mainfrom
Bodigrim:main
Apr 18, 2022
Merged

Switch from criterion to tasty-bench#410
chshersh merged 1 commit intokowainik:mainfrom
Bodigrim:main

Conversation

@Bodigrim
Copy link
Copy Markdown
Collaborator

Resolves #408.

I've also removed ghc-options: -threaded -with-rtsopts=-N from benchmark component. One is unlikely to intend running benchmarks concurrently, it's harmful for results. See haskell-prettyprinter/prettyprinter#197 for a similar discussion.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I've checked the build times and they've improved significantly 🚀

@chshersh chshersh merged commit 3011495 into kowainik:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from 'criterion' to 'tasty-bench'

2 participants