Raise upper bound on hashable#399
Merged
chshersh merged 3 commits intokowainik:mainfrom Apr 4, 2022
JackKelly-Bellroy:hashable-1.4
Merged
Raise upper bound on hashable#399chshersh merged 3 commits intokowainik:mainfrom JackKelly-Bellroy:hashable-1.4
hashable#399chshersh merged 3 commits intokowainik:mainfrom
JackKelly-Bellroy:hashable-1.4
Conversation
Member
|
Hi @JackKelly-Bellroy ! Regarding warning, I would say yes, I think we should add the CPP pragma so we will keep our eye on this one. |
Contributor
Author
|
CPP is done. There are several ways to do this: write constraint over multiple lines, CPP away the |
chshersh
approved these changes
Apr 4, 2022
Contributor
chshersh
left a comment
There was a problem hiding this comment.
Looks nice 🙂
Unfortunately, CPP is unavoidable. Probably we can remove it in some future after a while
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #394
Generates a couple of warnings with
hashable-1.4, becauseEqis now a superclass ofHashable:I can fix the type signatures with CPP if you like.
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.