Merged
Conversation
chshersh
reviewed
Aug 21, 2020
Contributor
chshersh
left a comment
There was a problem hiding this comment.
Looks great! Only a few suggestions 🙂
.hlint.yaml
Outdated
| name: "Use 'on' from Relude" | ||
| note: "'on' is already exported from Relude" | ||
| rhs: "on" | ||
| rhs: on |
Contributor
There was a problem hiding this comment.
Can you edit this manually back to "on"? This is happening because of the following issue in dhall-to-yaml tool:
Maybe it is already fixed in the latest version of dhall-json and update to the latest version won't update it automatically, but for now we need to change this line back to quoted string... 😞
src/Relude/Lifted/Env.hs
Outdated
| @@ -0,0 +1,41 @@ | |||
| {- | | |||
| Copyright: (c) 2018-2020 Kowainik | |||
Contributor
There was a problem hiding this comment.
This module created in this year, so we can leave only 2020 in here 🙂
Suggested change
| Copyright: (c) 2018-2020 Kowainik | |
| Copyright: (c) 2020 Kowainik |
Comment on lines
+38
to
+41
| lookupEnv :: MonadIO m => String -> m (Maybe String) | ||
| lookupEnv = liftIO . ENV.lookupEnv | ||
| {-# SPECIALIZE lookupEnv :: String -> IO (Maybe String) #-} | ||
| {-# INLINE lookupEnv #-} |
Contributor
There was a problem hiding this comment.
Nice and clean implementation! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #305
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.