Add lifted handle functions by rektrex · Pull Request #323 · kowainik/relude

rektrex · 2020-08-14T09:21:12Z

Resolves #314

Checklist:

HLint

I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
- I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
- I've generated the new .hlint.yaml file (see this instructions).

General

I've updated the CHANGELOG with the short description of my latest changes.
All new and existing tests pass.
I keep the code style used in the files I've changed (see style-guide for more details).
I've used the stylish-haskell file.
My change requires the documentation updates.
- I've updated the documentation accordingly.
I've added the [ci skip] text to the docs-only related commit's name.

hint-man

There is no place for me here... I will choose the truth I like.

vrom911

Neat work!
Thanks for the Inline and specialise pragmas everywhere! 👍🏼

vrom911 · 2020-08-23T10:33:44Z

src/Relude/Lifted.hs

 Lifted functions to work with stdin and stdout.
 -}
+{- $handle
+Lifted functions to work with IO Handles.


Suggested change

Lifted functions to work with IO Handles.

Lifted functions to work with 'Relude.Base.IO' 'Handle's.

vrom911 · 2020-08-23T10:37:22Z

src/Relude/Lifted/Handle.hs

+    , hIsEOF
+    , hSetBuffering
+    , hGetBuffering
+    , module System.IO


I would prefer to inline this export explicitly.
It is better for documentation and you can see straight away what is exported from this module without going into sources 🙂

chshersh

Nice work! A few suggestions from my side as well 🙂

src/Relude/Lifted/Handle.hs

chshersh · 2020-08-23T10:40:30Z

src/Relude/Lifted/Handle.hs

+Stability:   Stable
+Portability: Portable
+
+Lifted functions to with IO Handles.


Suggested change

Lifted functions to with IO Handles.

Lifted functions to work with 'IO' 'Handle's.

chshersh · 2020-08-23T10:42:16Z

src/Relude/Lifted/Handle.hs

+@since 0.8.0.0
+-}
+hSetBuffering :: MonadIO m => IO.Handle -> IO.BufferMode -> m ()
+hSetBuffering = (liftIO .) . IO.hSetBuffering


I would prefer a less point-free implementation

Suggested change

hSetBuffering = (liftIO .) . IO.hSetBuffering

hSetBuffering h = liftIO . IO.hSetBuffering h

chshersh · 2020-09-16T13:17:43Z

Hi @rektrex! I've noticed that there are still a few documentation suggestions left unfixed. Would you like to apply them as well, so we can proceed with this PR? Looking forward to having these changes merged after everything is done 🙂

.hlint.yaml

Co-authored-by: Veronika Romashkina <vrom911@gmail.com>

rektrex · 2020-09-21T15:25:34Z

Sorry, forgot to add [ci skip].

vrom911

Great! Thank you so much ✨

chshersh

Great work! 💪

chshersh · 2020-09-30T11:26:42Z

@rektrex Sorry for the delay in merge. Stack on Travis didn't work around that time, so the CI was failing. I've rerun the Travis CI, and it passed! 💚 Thanks again for the PR 👍

rektrex added 2 commits August 14, 2020 14:43

add lifted Handle functions

6dbe7d7

add updated hlint.dhall file

d86126b

rektrex requested review from chshersh and vrom911 as code owners August 14, 2020 09:21

hint-man bot approved these changes Aug 14, 2020

View reviewed changes

chshersh mentioned this pull request Aug 21, 2020

reexport hFlush #315

Closed

10 tasks

chshersh assigned rektrex Aug 21, 2020

chshersh added the reexport Reexport something new label Aug 21, 2020

small documentation fixes [ci skip]

75bbba6

vrom911 reviewed Aug 23, 2020

View reviewed changes

chshersh reviewed Aug 23, 2020

View reviewed changes

rektrex added 2 commits August 23, 2020 16:23

reexport BufferMode, and minor changes

2a3f7d4

fix conflicts

8b10f7d

documentation fixes [ci skip]

6bae189

vrom911 reviewed Sep 21, 2020

View reviewed changes

.hlint.yaml Outdated Show resolved Hide resolved

Update .hlint.yaml

fc067cb

Co-authored-by: Veronika Romashkina <vrom911@gmail.com>

vrom911 approved these changes Sep 21, 2020

View reviewed changes

chshersh approved these changes Sep 21, 2020

View reviewed changes

chshersh merged commit 61d85ea into kowainik:master Sep 30, 2020

	Lifted functions to work with IO Handles.
	Lifted functions to work with 'Relude.Base.IO' 'Handle's.

	Lifted functions to with IO Handles.
	Lifted functions to work with 'IO' 'Handle's.

	hSetBuffering = (liftIO .) . IO.hSetBuffering
	hSetBuffering h = liftIO . IO.hSetBuffering h

Uh oh!

Conversation

rektrex commented Aug 14, 2020

Checklist:

HLint

General

Uh oh!

hint-man bot left a comment

Choose a reason for hiding this comment

Uh oh!

vrom911 left a comment

Choose a reason for hiding this comment

Uh oh!

vrom911 Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

vrom911 Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

chshersh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chshersh Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

chshersh Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

chshersh commented Sep 16, 2020

Uh oh!

Uh oh!

rektrex commented Sep 21, 2020

Uh oh!

vrom911 left a comment

Choose a reason for hiding this comment

Uh oh!

chshersh left a comment

Choose a reason for hiding this comment

Uh oh!

chshersh commented Sep 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants