Skip to content

add foldr1 to Foldable1#322

Merged
vrom911 merged 1 commit intokowainik:masterfrom
rektrex:add_foldr1
Aug 14, 2020
Merged

add foldr1 to Foldable1#322
vrom911 merged 1 commit intokowainik:masterfrom
rektrex:add_foldr1

Conversation

@rektrex
Copy link
Copy Markdown
Collaborator

@rektrex rektrex commented Aug 13, 2020

Resolves #307

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Copy link
Copy Markdown
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏼

@vrom911 vrom911 added the extra Relude.Extra label Aug 14, 2020
@vrom911 vrom911 merged commit 7e67096 into kowainik:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra Relude.Extra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'foldr1' to the 'Foldable1' typeclass

2 participants