Skip to content

[#256] Fix partiality in 'cycle'#275

Merged
vrom911 merged 2 commits intomasterfrom
chshersh/256-Fix-partiality-in-cycle
May 11, 2020
Merged

[#256] Fix partiality in 'cycle'#275
vrom911 merged 2 commits intomasterfrom
chshersh/256-Fix-partiality-in-cycle

Conversation

@chshersh
Copy link
Copy Markdown
Contributor

Resolves #256

@chshersh chshersh added the enhancement New feature or request label May 11, 2020
@chshersh chshersh requested a review from vrom911 as a code owner May 11, 2020 20:07
@chshersh chshersh self-assigned this May 11, 2020
Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 🥇

-- $setup
-- >>> import Relude

{- | Creates an infinite list from a finite list by appending the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the difference with the cycle from Data.List in here?

Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@vrom911 vrom911 merged commit 62d97b2 into master May 11, 2020
@vrom911 vrom911 deleted the chshersh/256-Fix-partiality-in-cycle branch May 11, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix partiality in 'cycle'

2 participants