Skip to content

[#239] Re-export more STM functions.#240

Merged
vrom911 merged 2 commits intokowainik:masterfrom
mithrandi:239-more-TStuff
Jan 28, 2020
Merged

[#239] Re-export more STM functions.#240
vrom911 merged 2 commits intokowainik:masterfrom
mithrandi:239-more-TStuff

Conversation

@mithrandi
Copy link
Copy Markdown
Contributor

@mithrandi mithrandi commented Jan 26, 2020 •
edited
Loading

Resolves #239

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

hint-man[bot]
hint-man bot approved these changes Jan 26, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@mithrandi
Copy link
Copy Markdown
Contributor Author

mithrandi commented Jan 26, 2020

Let me know if I should remove names.

chshersh
chshersh reviewed Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding more reexports. I only don't want to reexport orElse and check since the names are too common. But other functions shouldn't introduce any conflicts so it's okay to reexport them.

@chshersh chshersh added the reexport Reexport something new label Jan 28, 2020
@mithrandi mithrandi removed their assignment Jan 28, 2020
@mithrandi mithrandi requested a review from chshersh January 28, 2020 16:05
chshersh
chshersh approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithrandi Thanks! This looks good 👍

vrom911
vrom911 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@vrom911 vrom911 merged commit 4518c2a into kowainik:master Jan 28, 2020
@mithrandi mithrandi deleted the 239-more-TStuff branch January 29, 2020 09:43
@chshersh chshersh added this to the v0.7.0.0: Refiner milestone Feb 25, 2020
@mithrandi
Copy link
Copy Markdown
Contributor Author

mithrandi commented Jan 3, 2021 •
edited
Loading

Note to future code spelunkers: instance Alternative STM where (<|>) = orElse; empty = retry and so you can use guard / guarded instead of check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrom911 vrom911 vrom911 approved these changes

+2 more reviewers

@chshersh chshersh chshersh approved these changes

@hint-man hint-man[bot] hint-man[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

reexport Reexport something new

Projects

None yet

Milestone

v0.7.0.0: Refiner

Development

Successfully merging this pull request may close these issues.

Relude.Lifted.Concurrent is awkward

3 participants

@mithrandi @chshersh @vrom911