Merged
Conversation
vrom911
approved these changes
Oct 30, 2019
Member
vrom911
left a comment
There was a problem hiding this comment.
So cool! And another custom type error! 👍
src/Relude/Extra/Validation.hs
Outdated
| short-circuting on the first error so you can display all possible errors at | ||
| once. Common use-cases include: | ||
|
|
||
| 1. Validating each input a form with multiple inputs. |
Member
There was a problem hiding this comment.
"a form" seems to be out of the context
Contributor
Author
There was a problem hiding this comment.
Ah, yeah, probably I missed a few words...
| errors inside 'Failure'. | ||
| 4. 'Semigroup': accumulate both 'Failure' and 'Success' with '<>'. | ||
| 5. 'Monoid': 'Success' that shores 'mempty'. | ||
| 6. 'Alternative': return first 'Success' or accumulate all errors inside 'Failure'. |
d7c5bd7 to
d657015
Compare
Resolves #221
d657015 to
238af33
Compare
Contributor
|
I notice that the doctests now only test laziness for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #221
I've also added
Monadinstance with custom type errors forValidationbecause why not if we already added a lot of such instances.