Skip to content

[#171] Add custom type errors in some places#222

Merged
vrom911 merged 2 commits intomasterfrom
chshersh/171-Add-custom-type-errors-in
Oct 30, 2019
Merged

[#171] Add custom type errors in some places#222
vrom911 merged 2 commits intomasterfrom
chshersh/171-Add-custom-type-errors-in

Conversation

@chshersh
Copy link
Copy Markdown
Contributor

Resolves #171

In addition, I also decided to specify more context in some other errors.

@chshersh chshersh added enhancement New feature or request doc README, Haddock documentation, tutorials labels Oct 29, 2019
@chshersh chshersh requested a review from vrom911 October 29, 2019 08:48
@chshersh chshersh self-assigned this Oct 29, 2019
Copy link
Copy Markdown
Contributor

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@chshersh chshersh force-pushed the chshersh/171-Add-custom-type-errors-in branch from 093044d to 1a18851 Compare October 29, 2019 08:50
Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! So useful 💪

@chshersh chshersh force-pushed the chshersh/171-Add-custom-type-errors-in branch from 1a18851 to a2a86da Compare October 29, 2019 09:10
@chshersh chshersh force-pushed the chshersh/171-Add-custom-type-errors-in branch from a2a86da to 3cc5980 Compare October 29, 2019 09:13
@chshersh chshersh force-pushed the chshersh/171-Add-custom-type-errors-in branch from 27d2cd8 to e352b7f Compare October 30, 2019 08:40
@chshersh
Copy link
Copy Markdown
Contributor Author

@vrom911 I managed to fix the CI! The code is not that pleasant but I believe we won't change it too often... I also checked the documentation it still looks ok, so this should be fine.

@vrom911 vrom911 merged commit 85ab6f9 into master Oct 30, 2019
@vrom911 vrom911 deleted the chshersh/171-Add-custom-type-errors-in branch October 30, 2019 08:53
@chshersh chshersh added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc README, Haddock documentation, tutorials enhancement New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom type errors in some places

2 participants