Skip to content

Implement type family Elem#209

Merged
chshersh merged 8 commits intokowainik:masterfrom
kutyel:elem
Oct 14, 2019
Merged

Implement type family Elem#209
chshersh merged 8 commits intokowainik:masterfrom
kutyel:elem

Conversation

@kutyel
Copy link
Copy Markdown
Contributor

@kutyel kutyel commented Oct 14, 2019

Resolves #170

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@chshersh chshersh requested review from chshersh and vrom911 October 14, 2019 10:40
@chshersh chshersh added extra Relude.Extra new Bring something new into library (add function or type or interface) labels Oct 14, 2019
Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for your work 👍

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kutyel Thanks for your contribution! Looks great 👍 Just a few minor stylistic suggestions 🙂

@kutyel kutyel requested a review from chshersh October 14, 2019 11:03
@chshersh
Copy link
Copy Markdown
Contributor

Nice work!

@chshersh chshersh merged commit edd2e71 into kowainik:master Oct 14, 2019
@kutyel kutyel deleted the elem branch October 14, 2019 11:27
@chshersh chshersh added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra Relude.Extra Hacktoberfest https://hacktoberfest.digitalocean.com/ new Bring something new into library (add function or type or interface)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Elem type family

3 participants