203: Implement Guarded Combinator#207
Merged
vrom911 merged 3 commits intokowainik:masterfrom Oct 12, 2019
Merged
Conversation
chshersh
reviewed
Oct 11, 2019
Contributor
chshersh
left a comment
There was a problem hiding this comment.
@JonathanLorimer Thanks for your contribution! The implementation is nice, I only have a couple of stylistic change requests. But overall -- nicely done 👍
chshersh
approved these changes
Oct 12, 2019
Contributor
chshersh
left a comment
There was a problem hiding this comment.
@JonathanLorimer Thanks for your contribution! This looks great 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #203
I think that I implemented it the way you want based on the type signature, but if I am wrong please let me know and I would be happy to fix it.
I am happy to write tests for this, but I couldn't see where this might fit in the
Testfolder.Also, I am not sure how to update the documentation, I added decorated comments in the same style as the rest of the code in that file (I assume that generates haddocks).
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.