Skip to content

203: Implement Guarded Combinator#207

Merged
vrom911 merged 3 commits intokowainik:masterfrom
JonathanLorimer:guarded-combinator
Oct 12, 2019
Merged

203: Implement Guarded Combinator#207
vrom911 merged 3 commits intokowainik:masterfrom
JonathanLorimer:guarded-combinator

Conversation

@JonathanLorimer
Copy link
Copy Markdown
Contributor

@JonathanLorimer JonathanLorimer commented Oct 11, 2019

Resolves #203

I think that I implemented it the way you want based on the type signature, but if I am wrong please let me know and I would be happy to fix it.

I am happy to write tests for this, but I couldn't see where this might fit in the Test folder.

Also, I am not sure how to update the documentation, I added decorated comments in the same style as the rest of the code in that file (I assume that generates haddocks).

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@chshersh chshersh requested review from chshersh and vrom911 October 11, 2019 18:44
@chshersh chshersh added the new Bring something new into library (add function or type or interface) label Oct 11, 2019
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonathanLorimer Thanks for your contribution! The implementation is nice, I only have a couple of stylistic change requests. But overall -- nicely done 👍

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonathanLorimer Thanks for your contribution! This looks great 👍

Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! Thanks 👍

@vrom911 vrom911 merged commit b2cad92 into kowainik:master Oct 12, 2019
@chshersh chshersh added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest https://hacktoberfest.digitalocean.com/ new Bring something new into library (add function or type or interface)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add guarded combinator

3 participants