Implement bimapBoth (#174)#202
Merged
vrom911 merged 4 commits intokowainik:masterfrom Oct 4, 2019
astynax:bimapBoth
Merged
Conversation
chshersh
suggested changes
Oct 3, 2019
src/Relude/Extra/Bifunctor.hs
Outdated
| [Left False,Right True] | ||
| >>> import Data.Functor.Const | ||
| >>> getConst $ bimapBoth (+ 1) (Const 41) | ||
| 42 |
Contributor
There was a problem hiding this comment.
Let's remove examples for triple and Const to decrease confusion 🙂 In most cases this function is going to be used with a pair or Either. So let's keep focus of documentation readers only on relevant examples. Experienced Haskell developers, who are familiar with Bifunctor, can generalise this function in their head.
src/Relude/Extra/Bifunctor.hs
Outdated
| secondF = fmap . second | ||
| {-# INLINE secondF #-} | ||
|
|
||
| {- | Maps a function over both elements of a bifunctor. |
Contributor
There was a problem hiding this comment.
Let's move this function in before bimapF to be consistent with the order of functions in the export list.
| @@ -16,7 +16,8 @@ qux :: Maybe (a, b) | |||
| -} | |||
Contributor
There was a problem hiding this comment.
We can add two more examples to the top-level docs:
xxx :: (a, a)
yyy :: Either a a
src/Relude/Extra/Tuple.hs
Outdated
| -} | ||
| mapBoth :: (a -> b) -> (a, a) -> (b, b) | ||
| mapBoth f (a1, a2) = (f a1, f a2) | ||
| {-# DEPRECATED mapBoth "Use Relude.Extra.Bifunctor.bimapBoth instead" #-} |
Contributor
There was a problem hiding this comment.
Minor reformatting to bring focus to relevant parts
Suggested change
| {-# DEPRECATED mapBoth "Use Relude.Extra.Bifunctor.bimapBoth instead" #-} | |
| {-# DEPRECATED mapBoth "Use 'bimapBoth' from "Relude.Extra.Bifunctor" instead" #-} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #174
General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.