Skip to content

Reexport foldMap' from new enough versions#200

Merged
chshersh merged 2 commits intokowainik:masterfrom
tfausak:patch-1
Oct 3, 2019
Merged

Reexport foldMap' from new enough versions#200
chshersh merged 2 commits intokowainik:masterfrom
tfausak:patch-1

Conversation

@tfausak
Copy link
Copy Markdown
Contributor

@tfausak tfausak commented Oct 3, 2019

Resolves #192

Although there are a couple HLint rules for foldMap, I'm not sure if they should be copied for foldMap'.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@vrom911 vrom911 requested review from chshersh and vrom911 October 3, 2019 05:00
@vrom911 vrom911 added Hacktoberfest https://hacktoberfest.digitalocean.com/ reexport Reexport something new labels Oct 3, 2019
Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! Thanks a lot for your work 👍

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfausak Thanks for your contribution!

@chshersh chshersh merged commit 78c307f into kowainik:master Oct 3, 2019
@tfausak tfausak deleted the patch-1 branch October 3, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest https://hacktoberfest.digitalocean.com/ reexport Reexport something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reexport foldMap' from Data.Foldable starting from base-4.13

3 participants