[#187] Remove tasty* dependencies#198
[#187] Remove tasty* dependencies#198vrom911 merged 7 commits intokowainik:masterfrom dalpd:187-remove-tasty
Conversation
vrom911
left a comment
There was a problem hiding this comment.
Very nice work! I have a few minor comments only 🙂
test/Test/Relude/Property.hs
Outdated
| , testProperty "Text to ByteString invertible" prop_TextToBytes | ||
| , testProperty "ByteString to Text or String invertible" prop_BytesTo | ||
| hedgehogTestList :: [IO Bool] | ||
| hedgehogTestList = [utfTest, listTest, logicTest] |
There was a problem hiding this comment.
I would move this function above the comment as the comment is related to utfProps function and co.
test/Test/Relude/Property.hs
Outdated
| module Test.Relude.Property | ||
| ( hedgehogTestTree | ||
| ) where | ||
| ( hedgehogTestList |
There was a problem hiding this comment.
By the style guide we use in the project, the previous indentation was correct, could we get back to that? 🙂
There was a problem hiding this comment.
Oh, sorry about that. 😅
test/Test/Relude/Property.hs
Outdated
| -- logicM | ||
| ---------------------------------------------------------------------------- | ||
|
|
||
| logicTest :: IO Bool |
There was a problem hiding this comment.
I guess it's okay to keep Prop suffixes to all property function, as they still contain property tests. There are ordinary unit tests for which suffix Test is more suitable 🙂
test/Spec.hs
Outdated
|
|
||
| main :: IO () | ||
| main = defaultMain hedgehogTestTree | ||
| main = sequence_ hedgehogTestList |
There was a problem hiding this comment.
I would prefer to use checkParallel instead of checkSequential. And also use the following style of tests from membrain:
These several lines are required to make tests work smoothly on Windows and on various CI services.
vrom911
left a comment
There was a problem hiding this comment.
Great! Thanks for your work 🥇
Resolves #187
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.