Implement asumMap and foldMapA by coercing foldMap#191
Merged
vrom911 merged 2 commits intokowainik:masterfrom Sep 21, 2019
Merged
Implement asumMap and foldMapA by coercing foldMap#191vrom911 merged 2 commits intokowainik:masterfrom
asumMap and foldMapA by coercing foldMap#191vrom911 merged 2 commits intokowainik:masterfrom
Conversation
chshersh
suggested changes
Sep 20, 2019
Contributor
chshersh
left a comment
There was a problem hiding this comment.
This looks like a good change 👍 I have several suggestions but overall seems nice.
vrom911
reviewed
Sep 21, 2019
This is how `fmapDefault` and `foldMapDefault` look in base, and is useful for the same reasons.
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
bdc1a21 to
53cdc57
Compare
vrom911
approved these changes
Sep 21, 2019
Contributor
Author
|
Note to self: If we ever have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how
fmapDefaultandfoldMapDefaultlook in base,and is useful for the same reasons.
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.