Skip to content

Use $> instead of *> and pure where possible#189

Merged
vrom911 merged 1 commit intokowainik:masterfrom
josephcsible:avoidapp
Sep 21, 2019
Merged

Use $> instead of *> and pure where possible#189
vrom911 merged 1 commit intokowainik:masterfrom
josephcsible:avoidapp

Conversation

@josephcsible
Copy link
Copy Markdown
Contributor

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring 👍

@josephcsible
Copy link
Copy Markdown
Contributor Author

Did you mean to assign this back to me? Is there anything further I need to do to this one?

@chshersh
Copy link
Copy Markdown
Contributor

@josephcsible Nothing more needs to be done in this PR yet!
Just all pull requests in this repo must have approval from both package maintainers before merging.

Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, @josephcsible 👍

@vrom911 vrom911 merged commit 0685ea3 into kowainik:master Sep 21, 2019
@josephcsible josephcsible deleted the avoidapp branch September 21, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants