Skip to content

#167 rename (prec -> prev) & (dupe -> dup)#185

Merged
vrom911 merged 6 commits intokowainik:masterfrom
Cmdv:#167-rename-prec-dupe
Sep 13, 2019
Merged

#167 rename (prec -> prev) & (dupe -> dup)#185
vrom911 merged 6 commits intokowainik:masterfrom
Cmdv:#167-rename-prec-dupe

Conversation

@Cmdv
Copy link
Copy Markdown
Contributor

@Cmdv Cmdv commented Sep 11, 2019

Resolves #167

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Cmdv! This is a nice small improvement to the library 🙂
I have one minor comment, but overall looks very nice 👍

@Cmdv
Copy link
Copy Markdown
Contributor Author

Cmdv commented Sep 12, 2019

made amends requested and regenerated the .hlint.yaml 😊

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. Thanks!

Copy link
Copy Markdown
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank for your lovely contribution, @Cmdv !

@vrom911 vrom911 merged commit 50ed105 into kowainik:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra Relude.Extra hlint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename prec in Relude.Extra.Enum to prev

3 participants