Skip to content

[#164] Reexport ShortByteString#184

Merged
chshersh merged 3 commits intomasterfrom
vrom911/164-Reexport-ShortByteString
Sep 11, 2019
Merged

[#164] Reexport ShortByteString#184
chshersh merged 3 commits intomasterfrom
vrom911/164-Reexport-ShortByteString

Conversation

@vrom911
Copy link
Copy Markdown
Member

@vrom911 vrom911 commented Sep 11, 2019

Resolves #164
and part of #148

I've decided to export toShort and fromShort functions as well. I checked hoogle and it seems that there is no much functions with such names, so there should be no collisions. But let me know if it's better to not reexport them.

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@vrom911 vrom911 added enhancement New feature or request reexport Reexport something new labels Sep 11, 2019
@vrom911 vrom911 added this to the v0.6.0.0: Refinement milestone Sep 11, 2019
@vrom911 vrom911 self-assigned this Sep 11, 2019
@vrom911 vrom911 requested a review from chshersh September 11, 2019 09:15
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

in let rule = constructors ./Rule.dhall
in [ rule.Arguments { arguments =
in let Rule = ./Rule.dhall
in [ Rule.Arguments { arguments =
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating Dhall version as well! 🙏

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@chshersh chshersh merged commit a6e670f into master Sep 11, 2019
@chshersh chshersh deleted the vrom911/164-Reexport-ShortByteString branch September 11, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request reexport Reexport something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reexport ShortByteString

2 participants