Conversation
…INLINABLE/INLINE pragmas Resolves #177
vrom911
approved these changes
Aug 17, 2019
| -- | Lifted version of 'System.Exit.exitWith'. | ||
| exitWith :: MonadIO m => ExitCode -> m a | ||
| exitWith a = liftIO (XIO.exitWith a) | ||
| {-# INLINE exitWith #-} |
Member
There was a problem hiding this comment.
What is the reasoning behind this?
Contributor
Author
There was a problem hiding this comment.
The reasoning is that if you call exit* functions, your program terminates and doesn't do anything else. So it doesn't make much sense to INLINE such functions, we can rely on GHC to do the right stuff. It's a minor micro-optimisation because abuse of INLINE can slow down compilation, but here I think we don't need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…INLINABLE/INLINE pragmas
Resolves #177
I had a discussion recently about
INLINE,SPECIALIZEandINLINEABLEpragmas. So I now understand these pragmas better. But the rules when to use them are still vague. So I tried to use my judgement to specify these pragmas where appropriately.This PR does the following:
InstanceSigsand signatures in some places.gitignoreStringtype toRelude.Stringfor consistencyChecklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.