Re-export atan2 from GHC.Float#165
Merged
chshersh merged 1 commit intokowainik:masterfrom Jun 17, 2019
ethercrow:patch-1
Merged
Re-export atan2 from GHC.Float#165chshersh merged 1 commit intokowainik:masterfrom ethercrow:patch-1
atan2 from GHC.Float#165chshersh merged 1 commit intokowainik:masterfrom
ethercrow:patch-1
Conversation
vrom911
reviewed
Jun 16, 2019
src/Relude/Numeric.hs
Outdated
| import GHC.Base (maxInt, minInt) | ||
| import GHC.Float (Double (..), Float (..), Floating (acos, acosh, asin, asinh, atan, atanh, cos, cosh, exp, logBase, pi, sin, sinh, sqrt, tan, tanh, (**)), | ||
| RealFloat (floatRadix, floatDigits, floatRange, decodeFloat, encodeFloat, isNaN, isInfinite, isDenormalized, isNegativeZero, isIEEE)) | ||
| RealFloat (floatRadix, floatDigits, floatRange, decodeFloat, encodeFloat, isNaN, isInfinite, isDenormalized, isNegativeZero, isIEEE), atan2) |
Member
There was a problem hiding this comment.
I see that atan2 is the method of the class RealFloat, you can add the import under the class as all the other functions here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing geometry without atan2 makes Jack a dull boy.
Checklist:
HLint
hlint.dhallaccordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.)..hlint.yamlfile (see this instructions).General
stylish-haskellfile.[ci skip]text to the docs-only related commit's name.