Skip to content

Implement Relude.Extra.Types module#163

Merged
chshersh merged 5 commits intokowainik:masterfrom
TheMatten:type-families
May 21, 2019
Merged

Implement Relude.Extra.Types module#163
chshersh merged 5 commits intokowainik:masterfrom
TheMatten:type-families

Conversation

@TheMatten
Copy link
Copy Markdown
Contributor

Resolves #156.

Additionally to type (++) it adds AllHave, Fst and Snd - should they be kept or removed for now?

Checklist:

HLint

  • I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).
    • I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
    • I've generated the new .hlint.yaml file (see this instructions).

General

  • I've updated the CHANGELOG with the short description of my latest changes.
  • All new and existing tests pass.
  • I keep the code style used in the files I've changed (see style-guide for more details).
  • I've used the stylish-haskell file.
  • My change requires the documentation updates.
    • I've updated the documentation accordingly.
  • I've added the [ci skip] text to the docs-only related commit's name.

@chshersh chshersh requested review from chshersh and vrom911 May 17, 2019 06:51
@chshersh chshersh added the extra Relude.Extra label May 17, 2019
Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just let's move all these functions to another module.

Copy link
Copy Markdown
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation!

@chshersh chshersh merged commit 75bc5a1 into kowainik:master May 21, 2019
@chshersh chshersh modified the milestone: v0.6.0.0: Refinement Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extra Relude.Extra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement common type-families in the Relude.Extra.Types module

2 participants