Skip to content

Don't run upgradeonfig on 1.23#31

Merged
NiLuJe merged 1 commit into
koreader:masterfrom
NiLuJe:master
May 24, 2021
Merged

Don't run upgradeonfig on 1.23#31
NiLuJe merged 1 commit into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented May 24, 2021

Copy link
Copy Markdown
Member

Fix #30


This change is Reviewable

@NiLuJe NiLuJe merged commit 22afdab into koreader:master May 24, 2021
@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

I still seem to be getting the same error with 22afdab?

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

As an aside, I don't think it's returning a proper failure state? Maybe it would like to set -e or something.

Edit: sorry, that's not true. I was confused with the Android TC, but that's more on me or Google.

@NiLuJe

NiLuJe commented May 24, 2021

Copy link
Copy Markdown
Member Author

I still seem to be getting the same error with 22afdab?

Right, we're not building in source here, I tested it with --enable-local :s.

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

Fixed in #32.

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

@NiLuJe Actually, the Kindle one didn't seem to produce any errors previously despite only building 2 TCs.

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

Which is not related to this repo… but I'm not really sure what's going on over there at a glance:

https://github.com/koreader/virdevenv/blob/99d346e67d24fa0040d0373f5196c95d5b6d2cbf/docker/ubuntu/kokindle/build_kindle_tc.sh#L8-L10

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

I think I'll just remove the || etc there; it's not like any of the others have that and it seems to hide errors a bit.

@NiLuJe

NiLuJe commented May 24, 2021

Copy link
Copy Markdown
Member Author

Err, yeah, that's super weird, definitely get rid of that ^^.

@NiLuJe

NiLuJe commented May 24, 2021

Copy link
Copy Markdown
Member Author

Also: it didn't fail because it's using a pinned (old) version of koxtoolchain ;).

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

Nope, I merely linked to the available online version. ;-)

@Frenzie

Frenzie commented May 24, 2021

Copy link
Copy Markdown
Member

Now pushed to koreader/virdevenv@a68a352

Unfortunately the version I just built wasn't based on those last three line changes, but I'm not going to build it again. :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PocketBook issue

2 participants