[build] CMake: Introduce DownloadProject module#851
Merged
Frenzie merged 2 commits intokoreader:masterfrom Mar 13, 2019
Merged
Conversation
This module is like FetchContent in CMake 3.11, but for the moment it may be more inviting to hackers not to require that yet. The principle is explained here: https://crascit.com/2015/07/25/cmake-gtest/ It allows us to work with CMake in a more natural environment for CMake-submodules, which are otherwise nigh-uncontrollable in between escaping variables in CMake syntax and CMake being extremely bad at taking command-line arguments. (A fact I utterly despise as a regular user just downloading a project to compile & try.) Upping the minimum CMake version over 3.3 should also allow us to get rid of a few braindead Android-related workarounds for sdcv, where we had to completely force-feed the `.a` suffix.
NiLuJe
approved these changes
Mar 13, 2019
Member
NiLuJe
left a comment
There was a problem hiding this comment.
I won't pretend to actually be able to follow CMake's arcane logic, but I get the idea, and this looks sound ;).
Member
Author
|
Drat, I hadn't noticed that the binary seems to be slightly larger. It's not as if 100-200 kB matters that much in the grand scheme of things, but still… I'd like to know why. mumble, mumble, mumble Edit: it might be accidentally being built as debug instead of release, come to think of it. |
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 14, 2019
I added a stub sometime last year, but never finished implementing it. Cf. koreader#851 (comment)
Frenzie
added a commit
that referenced
this pull request
Mar 14, 2019
I added a stub sometime last year, but never finished implementing it. Cf. #851 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module is like FetchContent in CMake 3.11, but for the moment it may be more inviting to hackers not to require that yet.
The principle is explained here: https://crascit.com/2015/07/25/cmake-gtest/
It allows us to work with CMake in a more natural environment for CMake-submodules, which are otherwise nigh-uncontrollable in between escaping variables in CMake syntax and CMake being extremely bad at taking command-line arguments. (A fact I utterly despise as a regular user just downloading a project to compile & try.)
Upping the minimum CMake version over 3.3 should also allow us to get rid of a few braindead Android-related workarounds for sdcv, where we had to completely force-feed the
.asuffix.