Skip to content

bump crengine, cre.cpp: add a few more PageMap / synthetic pages methods#2183

Merged
poire-z merged 2 commits into
koreader:masterfrom
poire-z:bump_crengine
Oct 4, 2025
Merged

bump crengine, cre.cpp: add a few more PageMap / synthetic pages methods#2183
poire-z merged 2 commits into
koreader:masterfrom
poire-z:bump_crengine

Conversation

@poire-z

@poire-z poire-z commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

bump crengine: fix buildSyntheticPageMap()

Includes:

cre.cpp: add a few more PageMap / synthetic pages methods

Will be useful to koreader/koreader#14405


This change is Reviewable

@hius07

hius07 commented Oct 4, 2025

Copy link
Copy Markdown
Member

Do we still need buildSyntheticPageMapIfNoneDocumentProvided?

@poire-z

poire-z commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

I thought I would remove them later, so there's no risk if this is being bumped into frontend soon and your PR coming only later. They are user patches using it in the wild :)
Unless you think I should ? (And you provide a way for these user-patches to not crash ?)

@hius07

hius07 commented Oct 4, 2025

Copy link
Copy Markdown
Member

We can keep CreDocument:buildSyntheticPageMapIfNoneDocumentProvided() and substitute the call in it.

@hius07

hius07 commented Oct 4, 2025

Copy link
Copy Markdown
Member

CreDocument.buildSyntheticPageMapIfNoneDocumentProvided = CreDocument.buildSyntheticPageMap

Together with adding the new methods.

@poire-z

poire-z commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

It would replace real pagemap with synthetic one for the people with the user-patch, wouldn't it ?
You'd need to quickly write a one that would work this evening so we can merge it in frontend (for you to advance on your work) without being able to test it.
Let's keep it and clean later ?

@hius07

hius07 commented Oct 4, 2025

Copy link
Copy Markdown
Member

Let's keep it and clean later ?

Yes, agree.

@poire-z poire-z merged commit 22fe4d6 into koreader:master Oct 4, 2025
4 checks passed
@poire-z poire-z deleted the bump_crengine branch October 4, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants