Skip to content

Fix brew not found on non-Mac platforms#1594

Merged
Frenzie merged 1 commit into
koreader:masterfrom
Frenzie:better-fix
Apr 2, 2023
Merged

Fix brew not found on non-Mac platforms#1594
Frenzie merged 1 commit into
koreader:masterfrom
Frenzie:better-fix

Conversation

@Frenzie

@Frenzie Frenzie commented Apr 2, 2023

Copy link
Copy Markdown
Member

Follow-up to #1593


This change is Reviewable

@Frenzie Frenzie merged commit 14bb24f into koreader:master Apr 2, 2023
@Frenzie Frenzie deleted the better-fix branch April 2, 2023 20:55
@NiLuJe

NiLuJe commented Apr 2, 2023

Copy link
Copy Markdown
Member

That'll lead to a concat with a nil, won't it? (i.e., this should have an else that sets it to the empty string).

@NiLuJe

NiLuJe commented Apr 2, 2023

Copy link
Copy Markdown
Member

Oh, hey, it does. Never mind me :D.

@NiLuJe

NiLuJe commented Apr 2, 2023

Copy link
Copy Markdown
Member

Oh, right, I was looking at the diff from the first PR. At least I'm not going entirely barmy, that's reassuring :D.

@Frenzie

Frenzie commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

Yeah, I wasn't paying close enough attention and I was also doing some experiments with Podman.

The tl;dr is you need something like this which I don't find very convenient (but I guess it's supposedly more secure, at least on a server):

podman unshare chown -R 1000:1000 koreader-for-building-android
podman run -v $(pwd)/koreader-for-building-android:/home/ko/koreader -it localhost/frans/koandroid:0.5.3 bash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants