Makefile.defs Use /bin/sh for $SHELL#1530
Closed
Baitinq wants to merge 1 commit into
Closed
Conversation
As we just use posix compatible shell scripts. Related koreader#1529
Member
|
The buildbot doesn't agree ;o). ({} list construct, but there may be others, so I wouldn't necessarily rock the boat there, as I guarantee that I may rant and rage |
Member
|
Well, I meant in the Makefile(s) which isn't the same thing as the separate scripts of course. ;-) Anyway, clearly we use {}. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we just use posix compatible shell scripts. Related #1529
This change is