ButtonTable, ReaderDogear and TextEditor tweaks and fixes#9985
Merged
Conversation
Prevent any later hold_release event from being handled by MovableContainer as a moving touch+hold_release. This issue was noticable when closing DictQuickLookup with long-press on close, resulting in the movable highlight actions ButtonTable moving to where the long-press happened.
Frenzie
approved these changes
Jan 1, 2023
hius07
reviewed
Jan 1, 2023
|
|
||
| function ReaderDogear:onSetPageMargins(margins) | ||
| if self.ui.document.info.has_pages then | ||
| if not self.ui.rolling then |
Member
There was a problem hiding this comment.
self.ui.paging doesn't work here?
Contributor
Author
There was a problem hiding this comment.
It does, but I thought it would be more readable to just use ui.rolling here, as all this stuff mostly regards ReaderRolling - than mixing not ui.paging and ui.rolling.
(And I assume the cost of not, if any, is cheap enough :)
Member
There was a problem hiding this comment.
Let me disagree and not to follow this.
Member
There was a problem hiding this comment.
I'd glanced over this change but yeah, this doesn't strike me as a case where using not adds clarity.
Contributor
|
Icons look neat! |
NiLuJe
approved these changes
Jan 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ButtonTable: reset MovableContainer state on button tap
Prevent any later hold_release event from being handled by MovableContainer as a moving touch+hold_release.
This issue was noticable when closing DictQuickLookup with long-press on close, resulting in the movable highlight actions ButtonTable moving to where the long-press happened.
Issue described at #9507 (comment), and various alternative solutions proposed in next posts.
ReaderDogear: fix no y-offset after load with top status bar
Regression since #9651, fix item 4 of #9979, #9979 (comment).
TextEditor: use a file symbol instead of numbers in history
Closes #9973 , by getting rid of the numbers :) and going with:
This change is