Skip to content

History: show last read date, adds Text editor to "Open with" dialog#6593

Merged
pazos merged 5 commits into
koreader:masterfrom
poire-z:histo_openwith
Aug 29, 2020
Merged

History: show last read date, adds Text editor to "Open with" dialog#6593
pazos merged 5 commits into
koreader:masterfrom
poire-z:histo_openwith

Conversation

@poire-z

@poire-z poire-z commented Aug 29, 2020

Copy link
Copy Markdown
Contributor

FileChooser: allow traversing unreadable directories
See #6508 (comment). Closes #6508. Ref #6379 (comment) #4885 (comment)

CoverBrowser: list mode: show fake cover when no cover
See #6058 (comment). Closes #6058.
Also bump base for lua-ljsqlite3 to use sqlite3_close_v2() koreader/koreader-base#1174 and avoid possible crashes #5563 (comment)

util: adds util.secondsToHour(), util.secondsToDate()
History: show last read date instead of file size
See #6041 (comment). Closes #6041.

image

image

Open with: add Text Editor plugin
See #5996 (comment). Implemented option B. Closes #5996.
image


This change is Reviewable

Also prevent very long directory names from overflowing
over neighbour items.
Also bump base for lua-ljsqlite3 to use sqlite3_close_v2()
and avoid possible crashes.
In classic and list display modes.
@hius07

hius07 commented Aug 29, 2020

Copy link
Copy Markdown
Member

Perfectly!

@Frenzie Frenzie added this to the 2020.09 milestone Aug 29, 2020
@Frenzie Frenzie added the UX label Aug 29, 2020

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lgtm!

@pazos pazos merged commit 85a16d0 into koreader:master Aug 29, 2020
@poire-z poire-z deleted the histo_openwith branch August 29, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants