[Plugin] Fix move to archive plugin names#6113
Merged
Frenzie merged 1 commit intokoreader:masterfrom May 3, 2020
Merged
Conversation
mwoz123
approved these changes
May 3, 2020
Frenzie
approved these changes
May 3, 2020
| local _ = require("gettext") | ||
| return { | ||
| name = "move_to_archive", | ||
| name = "movetoarchive", |
Member
There was a problem hiding this comment.
The before seems preferable to me? But yeah, I'd overlooked the move2archive one.
Contributor
Author
There was a problem hiding this comment.
We have no plugin with _ in the directory name.
Could have been "move2archive", as we have already "send2ebook", but well, not minding.
Member
There was a problem hiding this comment.
Oh, that was the problem? My bad, I interpreted it as just the mismatch between the metadata name and the widget name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mismatches in these names prevent this plugin from being disabled'able. #6101 (comment)
This change is